Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault is appearing in vroom in other package's revdep checks #510

Closed
jennybc opened this issue Sep 17, 2023 · 5 comments · Fixed by #512
Closed

Segfault is appearing in vroom in other package's revdep checks #510

jennybc opened this issue Sep 17, 2023 · 5 comments · Fixed by #512

Comments

@jennybc
Copy link
Member

jennybc commented Sep 17, 2023

... and in vroom's CI 😬

@jeroen
Copy link
Contributor

jeroen commented Sep 17, 2023

The problem disappears when we downgrade cpp11: #511

This might indicate one of two problems: either a bug in cpp11, or an abi change in cpp11 has caused a conflict that appears when multiple R packages are loaded which are built against different, incompatible versions of cpp11.

The latter can be ruled out by checking on Linux when building all packages from source (i.e. disable p3m).

@DavisVaughan
Copy link
Member

I would guess we can rule out an ABI change because ubuntu-release (devel) builds all packages from source and still fails https://github.com/tidyverse/vroom/actions/runs/6214248706/job/16866006817

Haven't been able to reproduce on mac though

@DavisVaughan
Copy link
Member

DavisVaughan commented Sep 17, 2023

I am fairly certain i have tracked it down to r-lib/cpp11@fe15211, but i still don't know exactly what is wrong

I can reproduce a hang on my mac with that commit installed and running

for (i in 1:10000) {
  out_file <- tempfile(fileext = "csv")
  vroom::vroom_write(mtcars, out_file, ",")
  unlink(out_file)
  print(i)
}

but not with

for (i in 1:10000) {
  vroom::vroom(I("x,y\n1,2\n3,4\n"), show_col_types = F)
  print(i)
}

@jeroen
Copy link
Contributor

jeroen commented Sep 21, 2023

Thanks for fixing this @jennybc @DavisVaughan !

@jennybc
Copy link
Member Author

jennybc commented Sep 21, 2023

It’s all @DavisVaughan! I’ll do a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants