-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault is appearing in vroom in other package's revdep checks #510
Comments
The problem disappears when we downgrade cpp11: #511 This might indicate one of two problems: either a bug in cpp11, or an abi change in cpp11 has caused a conflict that appears when multiple R packages are loaded which are built against different, incompatible versions of cpp11. The latter can be ruled out by checking on Linux when building all packages from source (i.e. disable p3m). |
I would guess we can rule out an ABI change because Haven't been able to reproduce on mac though |
I am fairly certain i have tracked it down to r-lib/cpp11@fe15211, but i still don't know exactly what is wrong I can reproduce a hang on my mac with that commit installed and running for (i in 1:10000) {
out_file <- tempfile(fileext = "csv")
vroom::vroom_write(mtcars, out_file, ",")
unlink(out_file)
print(i)
} but not with for (i in 1:10000) {
vroom::vroom(I("x,y\n1,2\n3,4\n"), show_col_types = F)
print(i)
} |
Thanks for fixing this @jennybc @DavisVaughan ! |
It’s all @DavisVaughan! I’ll do a release soon. |
... and in vroom's CI 😬
The text was updated successfully, but these errors were encountered: