Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check duplicate names in sql_translator() #1374

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Oct 6, 2023

Tests will fail because round() is defined twice for the base translation.

@mgirlich
Copy link
Collaborator

Good catch. Thanks for the PR!

@mgirlich mgirlich merged commit abd97b9 into main Oct 27, 2023
13 of 14 checks passed
@mgirlich mgirlich deleted the b-check-translator-dupes branch October 27, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants