Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slice_min/max() should sorting by multiple columns in dplyr style #1167

Closed
mgirlich opened this issue Feb 21, 2023 · 0 comments · Fixed by #1323
Closed

slice_min/max() should sorting by multiple columns in dplyr style #1167

mgirlich opened this issue Feb 21, 2023 · 0 comments · Fixed by #1323

Comments

@mgirlich
Copy link
Collaborator

Currently, they (accidentally) support sorting by multiple columns via c(col1, col2). For compatibility with dplyr this should give an error and instead the syntax tibble(col1, col2) should be supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Order by multiple variables in slice_min/max() tidyverse/dbplyr
1 participant
@mgirlich