New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random permutation of grads preceeds iteration over grads #20

Open

PierreQuinton opened this issue Jan 14, 2024 · 0 comments

PierreQuinton commented Jan 14, 2024

In the paper, the algorithm is the following:

I think this means that for every $i$, we randomly shuffle the order of the grads. In the code, the shuffling happens before iteration over the $i$, happening at the following line:
https://github.com/tianheyu927/PCGrad/blob/c5fbd7c856526373828074f06875230f7f3ee79e/PCGrad_tf.py#L36C11-L36C11

Would it be possible to know which of the two is supposed to be? And also, is this the code that was used for results of the paper?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment