Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏ Fix typo, "ASCII codes" to "ANSI escape sequences" #308

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

septatrix
Copy link
Contributor

ASCII is the encoding whereas ANSI escape sequences are what the terminals interpret for colors etc.

@svlandeg svlandeg added the docs Improvements or additions to documentation label Apr 21, 2022
@tiangolo tiangolo changed the title Fix usage of ASCII where it should be ANSI ✏ Fix typo, "ASCII codes" to "ANSI escape sequences" Jul 4, 2022
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

📝 Docs preview for commit f52cdf2 at: https://62c2b06fbafb1746ddfa2e90--typertiangolo.netlify.app

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #308 (f52cdf2) into master (d9b1788) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #308   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          253       253           
  Lines         5340      5340           
=========================================
  Hits          5340      5340           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b1788...f52cdf2. Read the comment docs.

@tiangolo
Copy link
Member

tiangolo commented Jul 4, 2022

Good catch, thank you! 🚀 🍰

@tiangolo tiangolo merged commit e56521f into fastapi:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants