Fix sqlalchemy class lookup #29
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge in tiangolo/master
Aligning with tiangolo master
ebreton
commented
May 20, 2019
tiangolo
requested changes
May 21, 2019
|
I will do that tomorrow 👌 |
|
Good morning @tiangolo , the Let me know whether there is anything else. I was hesitating for instance to add a new SubItem db_models to get automated testing and avoid regression (as described in #28), but I didn't... it seemed like too much noise... |
tiangolo
approved these changes
May 22, 2019
|
Awesome! Thanks a lot for your work 🎉 🍰 |
gusevyaroslove
pushed a commit
to gusevyaroslove/fastapi-template
that referenced
this pull request
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a one-line fix to avoid the crash of the application in certain edge cases, where you defined an SQLAlchemy relationship where one of the model is not yet imported at the time the application creates it initial data.
See Issue #28 for all the details