use poetry insted of Pipfile #144

RCheese · 2020-04-16T01:01:03Z

#123

tiangolo

Thanks for taking a stab at this! 🚀 🍰

I would like to do some small things a bit differently, I'm adding some comments here.

README.md

cookiecutter.json

{{cookiecutter.project_slug}}/backend/backend.dockerfile

{{cookiecutter.project_slug}}/backend/celeryworker.dockerfile

{{cookiecutter.project_slug}}/backend/make-requirements.sh

{{cookiecutter.project_slug}}/backend/requirements.txt

{{cookiecutter.project_slug}}/backend/tests.dockerfile

{{cookiecutter.project_slug}}/cookiecutter-config-file.yml

{{cookiecutter.project_slug}}/docker-compose.shared.base-images.yml

{{cookiecutter.project_slug}}/scripts/prepare.sh

RCheese · 2020-04-18T19:05:55Z

@tiangolo

https://python-poetry.org/docs/#installing-with-pip
What a reason for use poetry inside deployed container?

tiangolo · 2020-04-18T21:30:40Z

Thanks for your contribution! 🍰 I updated it a bit and it's now merged. 🚀 🎉

fastapi#69 fastapi#123 fastapi#144 fastapi/full-stack-fastapi-template@00297f9 Commit 00297f9 gitignored poetry.lock. This commit will add poetry.lock to version control with Git to avoid dependency resolution errors during Docker builds. There is no established convention for working with Poetry in Docker, so developers have to consider each use case individually. See: python-poetry/poetry#1879 (comment) In this project, the Dockerfile copies poetry.lock into the Docker image, but there's no step to generate poetry.lock in the first place. Without poetry.lock, dependency resolutions are commonly seen, such as: ```text ❯ bash scripts/test.sh WARNING: The following deploy sub-keys are not supported and have been ignored: labels WARNING: The following deploy sub-keys are not supported and have been ignored: labels WARNING: The following deploy sub-keys are not supported and have been ignored: labels WARNING: The following deploy sub-keys are not supported and have been ignored: labels WARNING: The following deploy sub-keys are not supported and have been ignored: labels db uses an image, skipping flower uses an image, skipping pgadmin uses an image, skipping proxy uses an image, skipping queue uses an image, skipping Building backend [+] Building 15.3s (8/10) => [internal] load build definition from backend.dockerfile 0.2s => => transferring dockerfile: 797B 0.1s => [internal] load .dockerignore 0.1s => => transferring context: 2B 0.0s => [internal] load metadata for ghcr.io/br3ndonland/inboard:fastapi-python3.9 0.3s => [1/6] FROM ghcr.io/br3ndonland/inboard:fastapi-python3.9@sha256:5591f436a37490a1569afd9e55ae 0.0s => [internal] load build context 0.0s => => transferring context: 64.67kB 0.0s => CACHED [2/6] COPY ./app/pyproject.toml ./app/poetry.lock* /app/ 0.0s => CACHED [3/6] WORKDIR /app/ 0.0s => ERROR [4/6] RUN bash -c "if [ true == 'true' ] ; then poetry install --no-root ; else poetr 14.4s ------ > [4/6] RUN bash -c "if [ true == 'true' ] ; then poetry install --no-root ; else poetry install --no-root --no-dev ; fi": Skipping virtualenv creation, as specified in config file. Installing dependencies from lock file Warning: The lock file is not up to date with the latest changes in pyproject.toml. You may be getting dependencies. Run update to update them. SolverProblemError Because app depends on sqlalchemy-stubs (^0.3) which doesn't match any versions, version solving failed. at /opt/poetry/lib/poetry/puzzle/solver.py:241 in _solve 237│ packages = result.packages 238│ except OverrideNeeded as e: 239│ return self.solve_in_compatibility_mode(e.overrides, use_latest=use_latest) 240│ except SolveFailure as e: → 241│ raise SolverProblemError(e) 242│ 243│ results = dict( 244│ depth_first_search( 245│ PackageNode(self._package, packages), aggregate_package_nodes ------ executor failed running [/bin/sh -c bash -c "if [ $INSTALL_DEV == 'true' ] ; then poetry install --no-root ; else poetry install --no-root --no-dev ; fi"]: exit code: 1 ERROR: Service 'backend' failed to build : Build failed ```

* use poetry insted of Pipfile * fix python black version * set prepare.sh as executable * revert postgres 11 * use multi-build stage in docker * fix poetry path * 🔥 Remove uneeded changes * 🔧 Move and update Poetry file * 🙈 Update gitignore * 🐳 Update Dockerfiles to use Poetry * 🐳 Update Dockerfiles with Poetry * 🔧 Add SERVER_NAME required by Celery worker * 🐳 Update Poetry install to avoid env conflicts * ➕ Add Pytest to Poetry dependencies Co-authored-by: Sebastián Ramírez <[email protected]>

tiangolo requested changes Apr 17, 2020

View reviewed changes

RCheese requested a review from tiangolo April 17, 2020 18:06

RCheese and others added 14 commits April 18, 2020 21:56

use poetry insted of Pipfile

e5443c8

fix python black version

abe4aeb

set prepare.sh as executable

098b822

revert postgres 11

9304c46

use multi-build stage in docker

006ecb2

fix poetry path

ed3f0e5

🔥 Remove uneeded changes

d7ddd0d

🔧 Move and update Poetry file

78f263c

🙈 Update gitignore

ba81213

🐳 Update Dockerfiles to use Poetry

bb06563

🐳 Update Dockerfiles with Poetry

d470c0d

🔧 Add SERVER_NAME required by Celery worker

421ba56

🐳 Update Poetry install to avoid env conflicts

238a0ad

➕ Add Pytest to Poetry dependencies

2d88bea

tiangolo force-pushed the feature/poetry branch from 20700a1 to 2d88bea Compare April 18, 2020 20:52

tiangolo merged commit c8bcc0b into fastapi:master Apr 18, 2020

br3ndonland mentioned this pull request Jul 19, 2021

Update back-end for inboard and Python 3.9 whythawk/full-stack-fastapi-postgresql#1

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use poetry insted of Pipfile #144

use poetry insted of Pipfile #144

RCheese commented Apr 16, 2020

tiangolo left a comment

RCheese commented Apr 18, 2020

tiangolo commented Apr 18, 2020

use poetry insted of Pipfile #144

use poetry insted of Pipfile #144

Conversation

RCheese commented Apr 16, 2020

tiangolo left a comment

Choose a reason for hiding this comment

RCheese commented Apr 18, 2020

tiangolo commented Apr 18, 2020