Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

no response when we use a wrong sig label #115

Open
1 task done
Rustin170506 opened this issue Sep 17, 2020 · 3 comments
Open
1 task done

no response when we use a wrong sig label #115

Rustin170506 opened this issue Sep 17, 2020 · 3 comments
Labels
lifecycle/rotten type/bug Categorizes issue or PR as related to a bug.

Comments

@Rustin170506
Copy link
Contributor

Bug Report

  • I have searched the issues of this repository and believe that this is not a duplicate.

Related link

None

Steps to reproduce(Optional)

Add a wrong sig label for issue.

What is expected?

It can be reported.

What is actually happening?

Nothing.

@Rustin170506 Rustin170506 added the type/bug Categorizes issue or PR as related to a bug. label Sep 17, 2020
@asuka730
Copy link

asuka730 commented Nov 25, 2020

I think it might be caused by typeorm query. We get a crash when the table join query could not build.

index.ts#L124

    // FIXME: now we use lower case sig label name, maybe we should fix it on github.
    const { sigId } = await this.githubLabelSigRepository
      .createQueryBuilder("gls")
      .leftJoinAndSelect(
        ProjectSig,
        "ps",
        "ps.project_sig_id = gls.project_sig_id"
      )
      .where(`gls.label = '${sigLabelName}'`)
      .select("ps.sig_id", "sigId")
      .getRawOne();

And returns with crashing.

@ti-chi-bot
Copy link
Member

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or hi-rustin.
/lifecycle stale

@ti-chi-bot
Copy link
Member

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or hi-rustin.
/lifecycle rotten

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/rotten type/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants