Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r132 #114

Closed
10 tasks done
joshuaellis opened this issue Aug 8, 2021 · 5 comments
Closed
10 tasks done

r132 #114

joshuaellis opened this issue Aug 8, 2021 · 5 comments
Labels
new release issues to do with the upcoming release of Three

Comments

@joshuaellis
Copy link
Member

joshuaellis commented Aug 8, 2021

Issue Tracker

This is used to track potential issues we need to investigate surrounding the r132 release.

Last checked: mrdoob/three.js@dc86b54624 (30 / 08 / 21).

@joshuaellis joshuaellis added the new release issues to do with the upcoming release of Three label Aug 8, 2021
@joshuaellis joshuaellis pinned this issue Aug 8, 2021
@0b5vr
Copy link
Contributor

0b5vr commented Aug 31, 2021

Removed .isBlack() method (mrdoob/three.js#22385)

It seems Color.isBlack is added and removed within the r132. We have nothing to do I believe.

@0b5vr
Copy link
Contributor

0b5vr commented Aug 31, 2021

MeshPhysicalMaterial: Promote ior to a material property (mrdoob/three.js#22238)

ior is promoted to an actual member value while reflectivity still exists as a get / set property (i.e. the standing of ior and reflectivity has been swapped).
If we want to do something about this, we might want to change the reflectivity to getter / setter instead of a member?

/**
* @default 0.5
*/
reflectivity: number;
/**
* @default 1.5
*/
ior: number;

@soadzoor
Copy link
Contributor

@joshuaellis Are we still missing some features for r132? When can we make a new release?

@Methuselah96
Copy link
Contributor

Methuselah96 commented Sep 13, 2021

@soadzoor Yeah, the unchecked items in the descriptions are what we're still missing. Once those those are completed we can make a new release. Feel free to contribute to help it get released more quickly!

@joshuaellis
Copy link
Member Author

Sorry folks, i've been incredibly busy at work and have neglected all my OSS work. Catching up now starting with this 💪🏼 r132 is in a PR in DT – DefinitelyTyped/DefinitelyTyped#55858

@joshuaellis joshuaellis unpinned this issue Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new release issues to do with the upcoming release of Three
Projects
None yet
Development

No branches or pull requests

4 participants