You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I realise we already have some credentials in the routemaster config file (specifically webhook API keys end up there), though I wonder whether we should look at a way to separate the configuration of the routemaster instance itself from the specification of the state machine. I'm not sure where the boundary for that is (it's certainly fuzzy at the moment), though I wonder whether this is something that will be needed if we want to be able to deploy the credentials in an explicitly secure manner.
Yep, we will need this, but I don't think we need it in this PR.
My thinking is that the configuration is relatively complex, and dynamic per plugin, and that it's nice to have config in one place (at least per plugin), so I think a mechanism to signal in the yaml to look for an environment variable instead might be the best option.
From #35...
@PeterJCLaw
@danpalmer
We should do this, or something similar.
The text was updated successfully, but these errors were encountered: