Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow fullscreen #196

Open
douglas-johnson opened this issue Jun 10, 2024 · 0 comments
Open

Disallow fullscreen #196

douglas-johnson opened this issue Jun 10, 2024 · 0 comments
Assignees

Comments

@douglas-johnson
Copy link
Member

douglas-johnson commented Jun 10, 2024

Background

When we did the layout refactor to use primarily WordPress core layout in both the editor and theme code, it changed the way alignfull works for us.

There are still some instance where we want to the legacy alignfull style, meaning a width of wide-size + ( global-padding * 2 ) so that it reaches the edge on smaller screen but has an upper limit.

In the child themes we have constrained some specific blocks like images and videos to enforce this upper limit, but we've written the CSS selector as :not(.allow-fullscreen) so that adding the class allow-fullscreen releases the constrained.

We have the opposite problem on some child themes where blocks like groups should normally not be constrained, but depending on the content we might want to declare a maximum size.

You can do that with the existing layout tools, but it requires some extra wrapping elements that are otherwise useless and you can't use calc() or a theme custom property like content-size.

Details

  • Can we use a custom class that constrains the width of an element that is already alignfull like .alignfull.disallow-fullscreen?
@douglas-johnson douglas-johnson self-assigned this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant