-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for Rails 8 #1213
Comments
As an aside, I wonder if the ability to upgrade an Engine would make for a good commit? I'll have to see if the upgrade process works on Engines. |
I've started to properly investigate this today, with an eye to trying to see how we could automate the testing flow. The plan is to run through these steps, which @stevepolitodesign shared with me previously:
First attempt, with the current release
Second attempt, with current
|
[our hero returns from lunch] Third attempt, some changes, running locallydiff --git a/lib/suspenders/version.rb b/lib/suspenders/version.rb
index 00621e5..54f5c6e 100644
--- a/lib/suspenders/version.rb
+++ b/lib/suspenders/version.rb
@@ -1,6 +1,6 @@
module Suspenders
VERSION = "20240516.0".freeze
- RAILS_VERSION = "~> 7.0".freeze
+ RAILS_VERSION = "~> 8.0".freeze
MINIMUM_RUBY_VERSION = ">= 3.1".freeze
MINIMUM_NODE_VERSION = "20.0.0".freeze
end diff --git a/lib/install/web.rb b/lib/install/web.rb
index b071c4d..4fc36a4 100644
--- a/lib/install/web.rb
+++ b/lib/install/web.rb
@@ -27,6 +27,8 @@ def apply_template!
gem_group :development, :test do
if ARGV.include?("--suspenders-main")
gem "suspenders", github: "thoughtbot/suspenders", branch: "main"
+ elsif ARGV.include?("--suspenders-local")
+ gem "suspenders", path: File.expand_path("~/projects/thoughtbot/suspenders")
else
gem "suspenders"
end $ rails new app_name \
--suspenders-local \
--skip-rubocop \
--skip-test \
-d=postgresql \
-m=~/projects/thoughtbot/suspenders/lib/install/web.rb Which is successful, then next:
|
I've got a branch in progress for loosening the constraint and also to upgrade the First, though, I need to do this so that we get a valid version of the diff --git a/Gemfile b/Gemfile
index 5688624..35eb962 100644
--- a/Gemfile
+++ b/Gemfile
@@ -6,7 +6,7 @@ gemspec
gem "puma"
-gem "sqlite3"
+gem "sqlite3", ">= 2.1"
# Start debugger with binding.b [https://github.com/ruby/debug]
# gem "debug", ">= 1.0.0" Then I can run: |
I've opened a PR now, with all the significant changes, including upgrading the |
I'm going to document my experience here as well:
In an effort to ensure we're using the latest code (not release) I used the command to build off
Which resulted in the following failure:
This corresponds with this comment. |
In the process of supporting Rails 8 via #1213, we realized we needed to install a local build. This commit simply introduces a `--suspenders-local` option, and documents how to build locally. Co-Authored-By: Nick Charlton <[email protected]>
In the process of supporting Rails 8 via #1213, we realized we needed to install a local build. This commit simply introduces a `--suspenders-local` option, and documents how to build locally. Co-Authored-By: Nick Charlton <[email protected]>
This |
With the upcoming release of Rails 8, we might want to consider re-generating the Engine to extract the dummy app. This way, our tests are running against a Rails 8 dummy app, and might catch regressions.
Additionally, I think we need to account for the following:
The text was updated successfully, but these errors were encountered: