-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matchers] primary_key_name is deprecated in Rails 3.1. #173
Comments
Thanks for reporting, it will be fixed in the next release by thoughtbot/shoulda-matchers@6b4035c |
@jasonm, any plans to release a new version? |
Is this out already? |
It appears this is not out, at least in a gem version. I believe the thoughtbot guys will have to roll a new version of the parent gem shoulda, which would pull in the new version of the matcher dependency...which should clean up this deprecation for Rails 3.1. Version 2.11.3 (latest in rubygems) still has the issue. |
What you can do is use: gem 'shoulda', '>= 3.0.0.beta' That version got rid of the warning. |
3.0.0.beta fixes the deprecations, but the matchers still aren't found with test/unit and the hack of require 'shoulda/rails' from #171 fails to work. Now that 3.1 is out I really want to upgrade, but it doesn't seem like anyone is using test/unit anymore over at thoughtbot, and I'm wondering if it's time to cut my losses and move off of shoulda. Does test/unit have a future in shoulda? |
I'm in the same boat as @dasil003. Should I simply abandon shoulda? |
+1. What'd you end up doing? Switch off of shoulda? |
hey guys,
just want to report that primary_key_name. sorry, iam not able right now to provide a patch. i think its in
The text was updated successfully, but these errors were encountered: