Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Re-enable custom fonts #761

Closed
jferris opened this issue Apr 10, 2015 · 3 comments
Closed

Re-enable custom fonts #761

jferris opened this issue Apr 10, 2015 · 3 comments
Milestone

Comments

@jferris
Copy link
Contributor

jferris commented Apr 10, 2015

I've been assuming that we'll allow custom fonts once we fully move to Qt 5. It seems like a good idea to enable this for Qt 5 users ahead of the big switch to make sure this is actually going to work, and then just enable it unconditionally in the 2.0 release.

@mhoran any thoughts?

@jferris jferris added this to the 1.6.0 milestone Apr 10, 2015
@mhoran
Copy link
Collaborator

mhoran commented Apr 17, 2015

I'd prefer to defer until a release candidate, as I'm a bit uneasy about introducing differences between identical c-w versions based on Qt version. We've been careful to minimize those differences to date, but it's also possible users won't install the RC and would then be surprised in the final release regardless.

@jferris jferris modified the milestones: 2.0.0, 1.6.0 Apr 20, 2015
@jferris
Copy link
Contributor Author

jferris commented Apr 20, 2015

Alright, I moved it to the 2.0.0 milestone. I'm mostly interested in proving that the crash is fixed on Qt 5.

@jferris jferris changed the title Re-enable custom fonts for Qt 5 users Re-enable custom fonts Apr 20, 2015
@mhoran
Copy link
Collaborator

mhoran commented Apr 21, 2015

I'm almost positive I tested this out back when I had access to an OS X machine. I also found that the text rendering implementation changed significantly between Qt 4 and 5 and could not reproduce the crash.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants