Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support query paremeter arguments on URL #215

Open
ahmadov opened this issue Jul 2, 2018 · 3 comments
Open

Support query paremeter arguments on URL #215

ahmadov opened this issue Jul 2, 2018 · 3 comments

Comments

@ahmadov
Copy link

ahmadov commented Jul 2, 2018

I need to send some data from client to server with query parameter, but as I noticed client and server URL have to be the same. These extra data is differ for each client /?id=129&type=data, maybe another req parameter could be added to read the URL.
somethink like that:
wss.on('connection', (ws, req) => {});

@ahmadov ahmadov changed the title Support query paremeter arguments on URL. Support query paremeter arguments on URL Jul 2, 2018
@aligg
Copy link

aligg commented Jan 7, 2019

Hey - we also ran into this issue today (cc @viggyfresh). If this is the case, it would at least be helpful to have this documented somewhere! Took us quite a bit of debugging and digging to figure out why things weren't working. Thanks!

@sechel
Copy link
Contributor

sechel commented Jul 24, 2019

This can be closed now that #271 is merged.

@tbuschto
Copy link

I think this is still an issue. #271 only fixed NetworkBridge.prototype.attachWebSocket method, but my understanding of the code is that serverLookup needs a similar fix for the client to find the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants