Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing shown on fitness trend page after selecting 24 months #538

Closed
florisvanwoudenberg opened this issue Mar 4, 2018 · 4 comments
Closed
Assignees

Comments

@florisvanwoudenberg
Copy link

Environment:

  • Plugin version: 6.01
  • Chrome/Opera/Chromium version: 64.0.3282.186
  • OS version: OSX 10.13.3

The problem:

Steps to reproduce:

  1. On the fitnesstrend page, select 24 months as the timeframe
  2. The page shows an empty bar, indicating that it is loading, but even after 5 minutes no result.
  3. It seems that the problem is that I do not have any activity from 24 month old. My oldest is about 18 months old, so the problem could be that.

Actual Behavior:

Warning shown: No start activity index found for this FROM date

Media attachement:

Attached 2 screenshots, one from console log and one from fitnesstrend page.
schermafbeelding 2018-03-04 om 14 18 26
schermafbeelding 2018-03-04 om 14 24 22

Sync history

To export you history click on "sync button" (top right and corner), then "Backup history". You can zip the file and upload it here.
2018.3.4-14.22_v6.0.1.history.json.zip

@thomaschampagne
Copy link
Owner

thomaschampagne commented Mar 4, 2018

@florisvanwoudenberg Seen! Thanks for reporting that bug. Indeed your first activity of all time on strava has a date of 2016/11/23.

My code and unit test mark this as failure when a from/to date is unknown in athlete history. Dumb i am !

I will use the date of the first known activity instead in that case ;)

Tom

@thomaschampagne
Copy link
Owner

@florisvanwoudenberg It's fixed !

Once the CI has finished that build (When it's green :))

Could you perform a quick test by using the latest CI build located here: https://bintray.com/thomaschampagne/stravistix/travis-ci-builds/develop#files ?

Reopen if not fixed !

Thanks for your help!

Tom

@thomaschampagne
Copy link
Owner

@florisvanwoudenberg
Copy link
Author

HI Thomas,

I tested the new build and can confirm that it works now as expected. Nothing breaks when no activity is available at the beginning of the timeframe.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants