From 9f1c4410ba79776499d16d1be2863fca57d54c0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20R=C3=B6hrich?= <47457568+felix-roehrich@users.noreply.github.com> Date: Tue, 10 Oct 2023 11:34:28 +0200 Subject: [PATCH 1/3] deprecate field_of_fractions --- src/FunField/Divisor.jl | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/FunField/Divisor.jl b/src/FunField/Divisor.jl index ff44c5d7b3..3ebdf28643 100644 --- a/src/FunField/Divisor.jl +++ b/src/FunField/Divisor.jl @@ -171,19 +171,16 @@ function ideals(D) end @doc raw""" - field_of_fractions(O::GenOrd) -> FunctionField function_field(O::GenOrd) -> FunctionField Return the function field of O. """ -function field_of_fractions(O::GenOrd) - return O.F -end - function function_field(O::GenOrd) return O.F end +@deprecate field_of_fractions function_field + @doc raw""" constant_field(K::FunctionField) -> Field From 1747129a324c6e83db3b1c495c84eafc5baeef04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20R=C3=B6hrich?= <47457568+felix-roehrich@users.noreply.github.com> Date: Tue, 10 Oct 2023 11:44:16 +0200 Subject: [PATCH 2/3] add call signature --- src/FunField/Divisor.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FunField/Divisor.jl b/src/FunField/Divisor.jl index 3ebdf28643..83901004c7 100644 --- a/src/FunField/Divisor.jl +++ b/src/FunField/Divisor.jl @@ -179,7 +179,7 @@ function function_field(O::GenOrd) return O.F end -@deprecate field_of_fractions function_field +@deprecate field_of_fractions(O::GenOrd) function_field(O::GenOrd) @doc raw""" constant_field(K::FunctionField) -> Field From c426b7205e846594cbbf0ba318ccf970db274962 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20R=C3=B6hrich?= <47457568+felix-roehrich@users.noreply.github.com> Date: Tue, 10 Oct 2023 09:55:02 +0000 Subject: [PATCH 3/3] move deprecation --- src/Deprecations.jl | 3 +++ src/FunField/Divisor.jl | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Deprecations.jl b/src/Deprecations.jl index e842888d5b..0845d23c39 100644 --- a/src/Deprecations.jl +++ b/src/Deprecations.jl @@ -115,6 +115,9 @@ @deprecate any_root(f::Hecke.AbstractAlgebra.Generic.Poly, F::Hecke.RelFinField) any_root(F, f) +# Deprecated during 0.22.* + +@deprecate field_of_fractions(O::GenOrd) function_field(O::GenOrd) # Things that moved to Nemo diff --git a/src/FunField/Divisor.jl b/src/FunField/Divisor.jl index 83901004c7..84cdd633db 100644 --- a/src/FunField/Divisor.jl +++ b/src/FunField/Divisor.jl @@ -179,8 +179,6 @@ function function_field(O::GenOrd) return O.F end -@deprecate field_of_fractions(O::GenOrd) function_field(O::GenOrd) - @doc raw""" constant_field(K::FunctionField) -> Field