Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base_ring_type for ClassField #1698

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

fingolfin
Copy link
Contributor

No description provided.

@thofma thofma enabled auto-merge (squash) December 5, 2024 18:27
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (cd361f4) to head (ab8304d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/RCF/class_fields.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1698      +/-   ##
==========================================
+ Coverage   75.89%   75.94%   +0.04%     
==========================================
  Files         362      362              
  Lines      114377   114377              
==========================================
+ Hits        86807    86864      +57     
+ Misses      27570    27513      -57     
Files with missing lines Coverage Δ
src/RCF/class_fields.jl 57.55% <0.00%> (ø)

... and 29 files with indirect coverage changes

@thofma thofma merged commit e76d83a into thofma:master Dec 5, 2024
17 checks passed
@fingolfin fingolfin deleted the mh/fix-base_ring_type-ClassField branch December 7, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants