Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Hecke map types down to AbstractAlgebra? #1230

Closed
lgoettgens opened this issue Sep 28, 2023 · 1 comment
Closed

Merge Hecke map types down to AbstractAlgebra? #1230

lgoettgens opened this issue Sep 28, 2023 · 1 comment

Comments

@lgoettgens
Copy link
Contributor

I think all functionality of HeckeMap can be instead added to the abstract AbstractAlgebra.Map type. Then, HeckeMap is no longer needed.

Furthermore, similar changes can be done with Hecke.MapFromFunc and AbstractAlgebra.FunctionalMap.

This would simplify and unify the usage and extensibility of map types everywhere from AbstractAlgebra up to Oscar.
@lgoettgens
Copy link
Contributor Author

After talking to @fieker and @thofma we decided to keep everything as is until there are some serious reasons to change.

@lgoettgens lgoettgens closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lgoettgens