diff --git a/src/Misc/Integer.jl b/src/Misc/Integer.jl index bdcf6b1aaa..24a59bfd2b 100644 --- a/src/Misc/Integer.jl +++ b/src/Misc/Integer.jl @@ -497,19 +497,19 @@ function issquare(x::fmpq) return x > 0 && issquare(numerator(x)) && issquare(denominator(x)) end -function issquare_with_root(x::fmpq) +function issquare_with_square_root(x::fmpq) if x < 0 return false, x else - fl, n = issquare_with_root(numerator(x)) + fl, n = issquare_with_square_root(numerator(x)) !fl && return false, x - fl, d = issquare_with_root(denominator(x)) + fl, d = issquare_with_square_root(denominator(x)) !fl && return false, x return true, fmpq(n, d) end end -function issquare_with_root(x::fmpz) +function issquare_with_square_root(x::fmpz) if !issquare(x) return false, x else diff --git a/src/NumField/NfAbs/Elem.jl b/src/NumField/NfAbs/Elem.jl index 60cc7dde45..c69a5463bb 100644 --- a/src/NumField/NfAbs/Elem.jl +++ b/src/NumField/NfAbs/Elem.jl @@ -840,7 +840,7 @@ Tests if $a$ is a square and return the root if possible. """ issquare(a::nf_elem) = ispower(a, 2) -issquare_with_root(a::NumFieldElem) = issquare(a) +issquare_with_square_root(a::NumFieldElem) = issquare(a) @doc Markdown.doc""" sqrt(a::nf_elem) -> nf_elem diff --git a/src/QuadForm/Quad/Spaces.jl b/src/QuadForm/Quad/Spaces.jl index 830b9cfdbc..75b018729b 100644 --- a/src/QuadForm/Quad/Spaces.jl +++ b/src/QuadForm/Quad/Spaces.jl @@ -1140,7 +1140,7 @@ function _isisotropic_with_vector(F::MatrixElem) end end - fl, y = issquare_with_root(-D[1]//D[2]) + fl, y = issquare_with_square_root(-D[1]//D[2]) if fl return true, elem_type(K)[T[1, k] + y * T[2, k] for k in 1:ncols(T)] elseif length(D) == 2