Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report all errors, not just the first one #50

Open
domenic opened this issue Sep 22, 2014 · 4 comments
Open

Report all errors, not just the first one #50

domenic opened this issue Sep 22, 2014 · 4 comments

Comments

@domenic
Copy link
Collaborator

domenic commented Sep 22, 2014

On

return { source: null, sourcemap: null, error: errors[0] };
we throw away all compile errors except the first one. That's sad.

@domenic
Copy link
Collaborator Author

domenic commented Sep 22, 2014

Also I kind of thought Traceur no longer threw an array but instead threw an aggregate error. So we might be doing something very wrong regardless.

@thlorenz
Copy link
Owner

We should ask the traceur team if/when there is ever more than one error.
If that is the case reasonably often we should start handling multiple errors and either combine them into one or emit/log each of them.

@domenic
Copy link
Collaborator Author

domenic commented Sep 22, 2014

@johnjbarton I believe was the one on the Traceur team looking in to this most.

@johnjbarton
Copy link

We currently throw an array but we have an aggregate error as well. Your feedback would be helpful.
https://github.com/google/traceur-compiler/blob/master/src/util/CollectingErrorReporter.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants