Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update isAuctionExpired function #642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: update isAuctionExpired function #642

wants to merge 2 commits into from

Conversation

karacurt
Copy link

@karacurt karacurt commented May 5, 2024 •
edited
Loading

Issue: This view function is semantically wrong, the auction is expired only if endTimestamp is less than block.timestamp.

Solution: Fixes operator sign to <= instead of >=

@karacurt karacurt mentioned this pull request May 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karacurt