Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seaport bulk sig support for smart accounts: AccountSeaportBulkSigSupport #633

Merged
merged 8 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,38 @@
[submodule "lib/solady"]
path = lib/solady
url = https://github.com/vectorized/solady
[submodule "lib/seaport"]
path = lib/seaport
url = https://github.com/ProjectOpenSea/seaport
[submodule "lib/murky"]
path = lib/murky
url = https://github.com/dmfxyz/murky
[submodule "lib/openzeppelin-contracts"]
path = lib/openzeppelin-contracts
url = https://github.com/openzeppelin/openzeppelin-contracts
[submodule "lib/solmate"]
path = lib/solmate
url = https://github.com/transmissions11/solmate
[submodule "lib/forge-std"]
path = lib/forge-std
url = https://github.com/foundry-rs/forge-std
branch = v1.5.0
[submodule "lib/solady"]
path = lib/solady
url = https://github.com/vectorized/solady
branch = v0.0.84
[submodule "lib/solarray"]
path = lib/solarray
url = https://github.com/emo-eth/solarray
[submodule "lib/ds-test"]
path = lib/ds-test
url = https://github.com/dapphub/ds-test
[submodule "lib/seaport-types"]
path = lib/seaport-types
url = https://github.com/projectopensea/seaport-types
[submodule "lib/seaport-core"]
path = lib/seaport-core
url = https://github.com/projectopensea/seaport-core
[submodule "lib/seaport-sol"]
path = lib/seaport-sol
url = https://github.com/projectopensea/seaport-sol
88 changes: 88 additions & 0 deletions contracts/extension/SeaportEIP1271.sol
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
// SPDX-License-Identifier: Apache-2.0
pragma solidity ^0.8.11;

import {ECDSA} from "solady/utils/ECDSA.sol";
import {SeaportOrderParser} from "./SeaportOrderParser.sol";
import {OrderParameters} from "seaport-types/src/lib/ConsiderationStructs.sol";

abstract contract SeaportEIP1271 is SeaportOrderParser {
using ECDSA for bytes32;

bytes32 private constant ACCOUNT_MESSAGE_TYPEHASH = keccak256("AccountMessage(bytes message)");
bytes32 private constant EIP712_TYPEHASH =
keccak256("EIP712Domain(string name,string version,uint256 chainId,address verifyingContract)");
bytes32 private immutable HASHED_NAME;
bytes32 private immutable HASHED_VERSION;

/// @notice The function selector of EIP1271.isValidSignature to be returned on sucessful signature verification.
bytes4 public constant MAGICVALUE = 0x1626ba7e;

constructor(string memory _name, string memory _version) {
HASHED_NAME = keccak256(bytes(_name));
HASHED_VERSION = keccak256(bytes(_version));
}

/// @notice See EIP-1271: https://eips.ethereum.org/EIPS/eip-1271
function isValidSignature(bytes32 _message, bytes memory _signature)
public
view
virtual
returns (bytes4 magicValue)
{
bytes32 targetDigest;
bytes memory targetSig;

// Handle OpenSea bulk order signatures that are >65 bytes in length.
if (_signature.length > 65) {
// Decode packed signature and order parameters.
(bytes memory extractedPackedSig, OrderParameters memory orderParameters, uint256 counter) =
abi.decode(_signature, (bytes, OrderParameters, uint256));

// Verify that the original digest matches the digest built with order parameters.
bytes32 domainSeparator = _buildSeaportDomainSeparator(msg.sender);
bytes32 orderHash = _deriveOrderHash(orderParameters, counter);

require(
_deriveEIP712Digest(domainSeparator, orderHash) == _message,
"Seaport: order hash does not match the provided message."
);

// Build bulk signature digest
targetDigest = _deriveEIP712Digest(domainSeparator, _computeBulkOrderProof(extractedPackedSig, orderHash));

// Extract the signature, which is the first 65 bytes
targetSig = new bytes(65);
for (uint256 i = 0; i < 65; i++) {
targetSig[i] = extractedPackedSig[i];
}
} else {
targetDigest = getMessageHash(_message);
targetSig = _signature;
}

address signer = targetDigest.recover(targetSig);

if (_isAuthorizedSigner(signer)) {
magicValue = MAGICVALUE;
}
}

/**
* @notice Returns the hash of message that should be signed for EIP1271 verification.
* @param _hash The message hash pre replay protection.
* @return messageHash The digest (with replay protection) to sign for EIP-1271 verification.
*/
function getMessageHash(bytes32 _hash) public view returns (bytes32) {
bytes32 messageHash = keccak256(abi.encode(_hash));
bytes32 typedDataHash = keccak256(abi.encode(ACCOUNT_MESSAGE_TYPEHASH, messageHash));
return keccak256(abi.encodePacked("\x19\x01", _accountDomainSeparator(), typedDataHash));
}

/// @notice Returns the EIP712 domain separator for the contract.
function _accountDomainSeparator() private view returns (bytes32) {
return keccak256(abi.encode(EIP712_TYPEHASH, HASHED_NAME, HASHED_VERSION, block.chainid, address(this)));
}

/// @notice Returns whether a given signer is an authorized signer for the contract.
function _isAuthorizedSigner(address _signer) internal view virtual returns (bool);
}
Loading
Loading