Custom errors, etc #619
Custom errors, etc #619
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -74,7 +84,10 @@ | |||
| function getAllPublishedContracts( | |||
| address _publisher | |||
| ) external view returns (CustomContractInstance[] memory published) { | |||
| CustomContractInstance[] memory linkedData = prevPublisher.getAllPublishedContracts(_publisher); | |||
| CustomContractInstance[] memory linkedData; | |||
Check warning
Code scanning / Slither
Uninitialized local variables Medium
| @@ -202,7 +225,10 @@ | |||
| function getPublishedUriFromCompilerUri( | |||
| string memory compilerMetadataUri | |||
| ) public view returns (string[] memory publishedMetadataUris) { | |||
| string[] memory linkedUris = prevPublisher.getPublishedUriFromCompilerUri(compilerMetadataUri); | |||
| string[] memory linkedUris; | |||
Check warning
Code scanning / Slither
Uninitialized local variables Medium
| _publisher, | ||
| _contractId | ||
| ); | ||
| CustomContractInstance[] memory linkedVersions; |
Check warning
Code scanning / Slither
Uninitialized local variables Medium
| _setupRole(DEFAULT_ADMIN_ROLE, _msgSender()); | ||
| constructor( | ||
| address _defaultAdmin, | ||
| address _trustedForwarder, |
Check notice
Code scanning / Slither
Local variable shadowing Low
| function _efficientHash(bytes32 a, bytes32 b) private pure returns (bytes32 value) { | ||
| /// @solidity memory-safe-assembly | ||
| assembly { | ||
| mstore(0x00, a) | ||
| mstore(0x20, b) | ||
| value := keccak256(0x00, 0x40) | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage Warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
==========================================
+ Coverage 64.55% 64.73% +0.17%
==========================================
Files 216 216
Lines 6701 6700 -1
==========================================
+ Hits 4326 4337 +11
+ Misses 2375 2363 -12 ☔ View full report in Codecov by Sentry. |
No description provided.