Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auction winner check in collectAuctionTokens in EnglishAuctionsLogic.sol #591

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

goldnite
Copy link
Contributor

There was no check for _msgSender() in collectionAuctionTokens.
I have changed following line to check if the _msgSender() is auction winner.
_winningBid.bidder != address(0) is not necessary because _msgSender() cannot be zero address.

  • original code
require(_winningBid.bidder != address(0), "Marketplace: no bids were made.");
  • suggested code
require(_winningBid.bidder == _msgSender(), "Marketplace: not auction winner.");

I have also changed term winning bidder to auction winner in the marketplace-v3.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants