Checkout #570

kumaryash90 · 2023-11-08T20:16:51Z

No description provided.

github-advanced-security

Slither found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

codecov · 2023-11-08T20:52:00Z

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (2568498) 64.08% compared to head (9d3b113) 63.85%.

Files	Patch %	Lines
contracts/prebuilts/unaudited/checkout/Vault.sol	30.23%	30 Missing ⚠️
...rebuilts/unaudited/checkout/prb/TargetCheckout.sol	31.42%	24 Missing ⚠️
...ontracts/prebuilts/unaudited/checkout/Executor.sol	80.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   64.08%   63.85%   -0.23%     
==========================================
  Files         215      220       +5     
  Lines        6632     6748     +116     
==========================================
+ Hits         4250     4309      +59     
- Misses       2382     2439      +57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contracts/prebuilts/unaudited/checkout/Checkout.sol

+contract Checkout is PermissionsEnumerable, ICheckout {
+    /// @dev Registry of vaults created through this Checkout
+    mapping(address => bool) public isVaultRegistered;
+
+    /// @dev Registry of executors created through this Checkout
+    mapping(address => bool) public isExecutorRegistered;
+
+    address public immutable vaultImplementation;
+    address public immutable executorImplementation;
+
+    constructor(
+        address _defaultAdmin,
+        address _vaultImplementation,
+        address _executorImplementation
+    ) {
+        vaultImplementation = _vaultImplementation;
+        executorImplementation = _executorImplementation;
+
+        _setupRole(DEFAULT_ADMIN_ROLE, _defaultAdmin);
+    }
+
+    function createVault(address _vaultAdmin, bytes32 _salt) external payable returns (address) {
+        bytes32 salthash = keccak256(abi.encodePacked(msg.sender, _salt));
+        address vault = Clones.cloneDeterministic(vaultImplementation, salthash);
+
+        (bool success, ) = vault.call(abi.encodeWithSelector(Vault.initialize.selector, _vaultAdmin));
+
+        require(success, "Deployment failed");
+
+        isVaultRegistered[vault] = true;
+
+        emit VaultCreated(vault, _vaultAdmin);
+
+        return vault;
+    }
+
+    function createExecutor(address _executorAdmin, bytes32 _salt) external payable returns (address) {
+        bytes32 salthash = keccak256(abi.encodePacked(msg.sender, _salt));
+        address executor = Clones.cloneDeterministic(executorImplementation, salthash);
+
+        (bool success, ) = executor.call(abi.encodeWithSelector(Executor.initialize.selector, _executorAdmin));
+
+        require(success, "Deployment failed");
+
+        isExecutorRegistered[executor] = true;
+
+        emit ExecutorCreated(executor, _executorAdmin);
+
+        return executor;
+    }
+
+    function authorizeVaultToExecutor(address _vault, address _executor) external {
+        require(IVault(_vault).canAuthorizeVaultToExecutor(msg.sender), "Not authorized");
+        require(isExecutorRegistered[_executor], "Executor not found");
+
+        IVault(_vault).setExecutor(_executor);
+
+        emit VaultAuthorizedToExecutor(_vault, _executor);
+    }
+}


contracts/prebuilts/unaudited/checkout/Executor.sol

+    function execute(UserOp calldata op) external {
+        require(_canExecute(), "Not authorized");
+
+        if (op.valueToSend != 0) {
+            IVault(op.vault).transferTokensToExecutor(op.currency, op.valueToSend);
+        }
+
+        bool success;
+        if (op.currency == CurrencyTransferLib.NATIVE_TOKEN) {
+            (success, ) = op.target.call{ value: op.valueToSend }(op.data);
+        } else {
+            if (op.approvalRequired) {
+                IERC20(op.currency).approve(op.target, op.valueToSend);
+            }
+
+            (success, ) = op.target.call(op.data);
+        }
+
+        require(success, "Execution failed");
+    }


contracts/prebuilts/unaudited/checkout/Checkout.sol

+    function createExecutor(address _executorAdmin, bytes32 _salt) external payable returns (address) {
+        bytes32 salthash = keccak256(abi.encodePacked(msg.sender, _salt));
+        address executor = Clones.cloneDeterministic(executorImplementation, salthash);
+
+        (bool success, ) = executor.call(abi.encodeWithSelector(Executor.initialize.selector, _executorAdmin));
+
+        require(success, "Deployment failed");
+
+        isExecutorRegistered[executor] = true;
+
+        emit ExecutorCreated(executor, _executorAdmin);
+
+        return executor;
+    }


contracts/prebuilts/unaudited/checkout/Checkout.sol

+    function createVault(address _vaultAdmin, bytes32 _salt) external payable returns (address) {
+        bytes32 salthash = keccak256(abi.encodePacked(msg.sender, _salt));
+        address vault = Clones.cloneDeterministic(vaultImplementation, salthash);
+
+        (bool success, ) = vault.call(abi.encodeWithSelector(Vault.initialize.selector, _vaultAdmin));
+
+        require(success, "Deployment failed");
+
+        isVaultRegistered[vault] = true;
+
+        emit VaultCreated(vault, _vaultAdmin);
+
+        return vault;
+    }
