Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Vulnerbility #54

Closed
Hypnos3 opened this issue Jan 4, 2019 · 7 comments
Closed

Security Vulnerbility #54

Hypnos3 opened this issue Jan 4, 2019 · 7 comments

Comments

@Hypnos3
Copy link

Hypnos3 commented Jan 4, 2019

I have get an issue from @rgerrans.
This issue is depending on the used protobuf version:

title

Is it possible to update the used version?

@lacker
Copy link

lacker commented Jun 12, 2019

npm is starting to warn about the dependency here, too. Although since it's been a couple years since this repo has been updated, I won't hold my breath.

@rgerrans
Copy link

npm is starting to warn about the dependency here, too. Although since it's been a couple years since this repo has been updated, I won't hold my breath.

I ended up switching to https://github.com/Hypnos3/node-red-contrib-cast

@dsteinman
Copy link

dsteinman commented Jun 15, 2019

Upgrading the dependency to 5.0.3 works, at least I didn't encounter anything that broke with this change yet.

"dependencies": {
    "debug": "^2.2.0",
    "protobufjs": "^5.0.3"
  },

@Saiv46
Copy link

Saiv46 commented Jul 21, 2019

Any progress here? npm audit still reporting this vulnerable package.

@feross
Copy link
Collaborator

feross commented Aug 5, 2019

Hi everyone, I have a pull request that fixes this issue but I don't have a Chromecast handy at the moment to test it out. Can someone confirm that the code in this pull request still works correctly?

#56

@Hypnos3
Copy link
Author

Hypnos3 commented Aug 5, 2019

Thank you for the change. I can test not before end of next week.

@feross feross closed this as completed in 1fe822f Sep 4, 2019
@feross
Copy link
Collaborator

feross commented Sep 4, 2019

Fixed in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants