Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloader State, Progress Property, Writable Filename & Multiple Downloads Example #26

Merged
merged 2 commits into from
Apr 29, 2014

Conversation

albertschulz
Copy link
Contributor

• added state property (ready, downloading, cancelled, failed, done)
• progress property (also for the delegate and block methods)
• writeable filename

• added example to show multiple file download in tableview

• progress property (also for the delegate and block methods)
• writeable filename

• added example to show multiple file download in tableview
@albertschulz
Copy link
Contributor Author

Please check the new example I added to demonstrate multiple downloads. There is a strange behavior you wouldn't expect when downloading multiple files: the remaining time is wrong for the new added file downloads

@albertschulz
Copy link
Contributor Author

Okay I fixed my problem by changing the context of previousTotal and remove it as static variable, changed it to an instance variable. Why did you define it as static? whats was your idea?

@thibaultcha
Copy link
Owner

Ohh stupid mistake!! It's not even supposed to be here ! It should be an instance variable! I was just developing the "remaining time" feature and I was too lazy to scroll up and add it as instance variable, so I did that... Sorry. Can you make it an instance variable? In the .m thanks for seeing that

I forgot about seeing the pull request today, I will tomorrow :)

@albertschulz
Copy link
Contributor Author

Hehe okay :) I already did as you can see in this commit:

albertschulz@e056ff7

@thibaultcha
Copy link
Owner

Ok cool thanks. (I'm on my phone).
FIY/Protip: GitHub is able to recognize just the Sha1 signature (even just first digits) as a link to the commit ;)

@albertschulz
Copy link
Contributor Author

Ahh very nice. Just pasted the link here and was happy that it automatically recognized it as a github commit. But well here you go:
e056ff7 :P

@thibaultcha
Copy link
Owner

Ok, it seems good to me (I will probably do some small changes before releasing 1.6)

The multiple download example is very needed, because I think many people look for that, so thank you for implementing it! You just forgot to update the startDownload with block method signature for the progress block in the .h, but I'll do it :)

thibaultcha added a commit that referenced this pull request Apr 29, 2014
Downloader State, Progress Property, Writable Filename & Multiple Downloads Example
@thibaultcha thibaultcha merged commit b9e94ab into thibaultcha:master Apr 29, 2014
thibaultcha added a commit that referenced this pull request May 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants