-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downloader State, Progress Property, Writable Filename & Multiple Downloads Example #26
Conversation
• progress property (also for the delegate and block methods) • writeable filename • added example to show multiple file download in tableview
Please check the new example I added to demonstrate multiple downloads. There is a strange behavior you wouldn't expect when downloading multiple files: the remaining time is wrong for the new added file downloads |
Okay I fixed my problem by changing the context of previousTotal and remove it as static variable, changed it to an instance variable. Why did you define it as static? whats was your idea? |
Ohh stupid mistake!! It's not even supposed to be here ! It should be an instance variable! I was just developing the "remaining time" feature and I was too lazy to scroll up and add it as instance variable, so I did that... Sorry. Can you make it an instance variable? In the .m thanks for seeing that I forgot about seeing the pull request today, I will tomorrow :) |
Hehe okay :) I already did as you can see in this commit: |
Ok cool thanks. (I'm on my phone). |
Ahh very nice. Just pasted the link here and was happy that it automatically recognized it as a github commit. But well here you go: |
Ok, it seems good to me (I will probably do some small changes before releasing 1.6) The multiple download example is very needed, because I think many people look for that, so thank you for implementing it! You just forgot to update the startDownload with block method signature for the progress block in the .h, but I'll do it :) |
Downloader State, Progress Property, Writable Filename & Multiple Downloads Example
Better multiple downloads example
• added state property (ready, downloading, cancelled, failed, done)
• progress property (also for the delegate and block methods)
• writeable filename
• added example to show multiple file download in tableview