Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong folder name when building #187

Open
luyatshimbalanga opened this issue Dec 28, 2020 · 3 comments
Open

Wrong folder name when building #187

luyatshimbalanga opened this issue Dec 28, 2020 · 3 comments
Assignees

Comments

@luyatshimbalanga
Copy link

The current tarball 0.2.6 contains the folder named "gpick-gpick-0.2.6" instead of "gpick-0.2.6" which suggests a typing error. As a result, the build will fail.

@thezbyg
Copy link
Owner

thezbyg commented Dec 28, 2020

Release and tag tarballs are generated automatically by GitHub. I think that the name of archive file and top folder is a concatenation of project name and commit reference. Release tags are named with gpick- prefix, so final names include double prefixes and this is not a typo. As far as I understand, the only way to change this is to rename tags in repository.

Folder name should not have any influence on the build process. I just tested your linked tarball with both CMake and SCons build systems, and it builds without issues. Could you explain in more detail how your build fails?

@thezbyg thezbyg self-assigned this Dec 28, 2020
@luyatshimbalanga
Copy link
Author

Prior to 0.2.6rc1, the previous tarball lacked extra prefix as highlighted by this diff as testing on Fedora build where %name is "gpick".
Although the fix was simple, it will be great to prevent such minor issue for future packagers.

@ryandesign
Copy link
Contributor

I think this can be closed as completed. As was said above, GitHub decides what folder name to use for automatically-generated tarballs. To avoid this and other problems inherent in automatically-generated tarballs, projects should manually generate tarballs and upload them to each GitHub release. It looks like the gpick project once again manually generates and uploads tarballs as of version 0.3. It previously did so on Google Code for versions 0.2.5 and earlier. Only version 0.2.6 did not get a manually-created tarball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants