Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo list #6

Closed
25 of 30 tasks
octopusinvitro opened this issue Jan 11, 2017 · 1 comment
Closed
25 of 30 tasks

ToDo list #6

octopusinvitro opened this issue Jan 11, 2017 · 1 comment

Comments

@octopusinvitro
Copy link
Contributor

octopusinvitro commented Jan 11, 2017

To-Do list

Legend:

  • πŸ˜„ finished
  • 🚧 under construction
  • βŒ› waiting

All the time

  • Check that what we do separates SYE specific stuff from the more generic code

Data

Extra modules

  • 🚧 Breadcrumbs - WIP
  • Site and PU search box (just one box that does both things) - (in pages: democratic resources, posts, events, elections, about) (implementation in the Jekyll version of the site)
  • Google analytics
  • Comments (facebook or disqus)
  • πŸ˜„ Not a module but add a boolean featured field in the summaries frontmatter in prose.io

Scripts

  • πŸ˜„ Finish deploy script to clone the prose repo, clone the sinatra repo, run the app, scrape the site and push to the static repo. Set up a webhook for prose?

Pages

All those "nice-to-have" comments: It's probably better to leave them for when the rest of the site is finished

  • πŸ˜„ Posts - Maybe add a method to show a summary instead of the whole post contents.
    From the requirements document:

Nice to have would be the most current blogs from the current month on the news page with a side menu bar that allows you to see blogs organised via month + year ( eg July 2016)

  • πŸ˜„ Post

  • 404 - easy ---> WE MAY NOT NEED IT ✨

  • πŸ˜„ About

  • πŸ˜„ Democracy resources

  • πŸ˜„ Government officials

  • 🚧 Government officials/Senators - similar to reps

  • πŸ˜„ Government officials/Representatives

  • Government officials/Governors - similar to reps. May need to interact with morph API to get the data or add a webhook to download the csv everytime the file changes?

  • πŸ˜„ Places. the links point to the reps and senators pages.

  • 🚧 Places/subpages the official site has three subpages more. They are all static pages that render EP data.

  • 🚧 Place page

  • πŸ˜„ Events. From the document:

Nice to have would be the most current events from the current month on the events page with a side menu bar that allows you to see events organised via month + year ( eg July 2016)
Nice to have would be a calendar for events.

  • πŸ˜„ Person page
    The url adds the house slug, but the official site doesn't have it. We must remove it in the route. Also, check the requirements document and the official site as there are more things than in the Jekyll site. We also need to implement:

    • 🚧 summary
  • πŸ˜„ Home

  • πŸ˜„ Elections. From the requirements document:

Desirable: Links to pages in the desirable section on voting information, Past Elections and re-runs.

  • 🚧 Elections/subpages - According to the document, seems like they want them listed in a submenu dropdown. They are all static pages edited by them, so will be available on prose.

Other

  • Map Pombola slugs to person pages
  • Add coveralls βœ”οΈ
  • Add metrics
  • Add rubocop βœ”οΈ
  • PR to prose to fix filenames saved with a date?
  • Tables in markdown
  • Update README and also add relevant badges βœ”οΈ
  • html validation?

To think about

  • Summaries: We can save them with the member id as filename, then add an edit button in the person page. Prose gives you a nice url pointing to the edit page of a document. This url could be passed in the person page inside of an edit button that they can click to edit a person summary. If you are not logged in you can edit but not save. We would have to think if there can be any security issues with access although that may be handled by github (access permissions to repos) βœ”οΈ
  • How to extract a gem from viewer-sinatra shared code. We don't need any of the pages there except maybe the TermTable page, but the PersonCard class seems like it is waiting to be simplified.
  • Create a rake task that checks out a specific sha of the prose directory before running the tests? or leave our prose directory always at that sha? βœ”οΈ
  • How to import Struan's governors βœ”οΈ

What could be extracted into a parliament monitoring site gem

Probably only just what's in the lib folder, so avoid having SYE specific stuff entangled with the code there?
Another thought: We could make some kind of generator like the ones you can build with yeoman. then we could put the generator into a gem, and just do something like pm-site-generator new sitename, just as Jekyll provides jekyll new sitename. That would generate a sinatra skeleton with our extra pm stuff. We could still move some of the code inside lib to tiny gems

Things to maybe implement in the future:

@mhl
Copy link
Contributor

mhl commented Mar 27, 2017

These are mostly addressed now, and I think the other requirements from our partners should be represented by other tickets.

@mhl mhl closed this as completed Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants