Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protection from malicious gateway? #2

Open
jku opened this issue Aug 24, 2023 · 3 comments
Open

protection from malicious gateway? #2

jku opened this issue Aug 24, 2023 · 3 comments

Comments

@jku
Copy link
Member

jku commented Aug 24, 2023

This is something I tried to ask in a community meeting when this was presented but maybe could not articulate...

I understand that IPFS is content addressable so the integrity check is builtin. I understand the gateway ends up doing that integrity check just as a side effect of finding the content. But what prevents the gateway from returning something malicious?

I don't see this client verifying the IPFS hash in any way? Am I missing something?

I do see in TAP-19:

the ecosystem is responsible for verifying artifact integrity at the time of use of the artifact

I didn't imagine it would mean trusting a remote server.

@shubham4443
Copy link
Contributor

Hi @jku

This issue is addressed in the latest update of docs - https://github.com/JustinCappos/tuf-ipfs#issue-with-public-gateways. I should've brought this up in the last community meeting but completely forgot about it. Also another workaround is having multiple hashes (e.g. sha256) along with IPFS CID to be extra secure.

@jku
Copy link
Member Author

jku commented Aug 26, 2023

Thanks, new README makes a lot more sense. It would be even better if it explicitly stated that the current implementation is based on complete trust on the gateway (and maybe explained why this is the case and how it could be improved in future).

I'm not focusing on this to downplay the work here at all: I filed this because to me these findings are the most important results of this work and should be really prominent -- stuff that Future Work will be based on.

This looks fixed to me, feel free to close

@shubham4443
Copy link
Contributor

Hi @jku

I have added additional detail on issue with gateways: https://github.com/JustinCappos/tuf-ipfs/tree/main#issue-with-public-gateways

Please look at it and let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants