Socket timeout default value pretty onerous

[trishankkarthik]

Don't know what I was thinking when I set the default socket timeout value to be 1 second, but it turns out to be pretty impractical in practice (e.g. client fails to connect via WiFi to server on the same LAN). Minor issue, but should reconsider.

[trishankkarthik]

Oh, wait, now I remember. It's because the same timeout value is used for both opening and reading a connection. We did some back-of-the-envelope calculation to ensure that, say, a 2MB file won't take an absurd amount of time to download (e.g. a server that deliberately delivered the file as slowly as possible would take at most, assuming 8KB chunks, (2_1024_1024)/8192 = 256secs = 4.267min).

Should separate timeout limits for an open vs read.

[lukpueh]

SOCKET_TIMEOUT has in the meanwhile been tweaked several times (see git log -L :SOCKET_TIMEOUT:tuf/settings.py). Currently it's at 4 seconds. And there is a pending PR that splits it into SOCKET_CONNECT_TIMEOUT = 10 and SOCKET_INTERBYTE_TIMEOUT = 4. I think we can close this issue.