-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata API: Consider including filename in TargetFile/MetaFile #1411
Comments
relates to #1317 |
I think it makes sense to implement this for the use case that we are sure about - add a path in |
I am working on this one already. |
I decided to propose a pr adding target name in |
I had a look in our code at how we are using |
Sounds good. |
Currently TargetFile and Metafile do not contain the filename of the file they represent. The API itself does not need it but it could be useful for users of the api.
As an example the current client returns a dict for get_one_valid_targetinfo(): that dict contains a filepath field and and a targetinfo field (essentially TargetFile). I would like to keep a similar API but avoid hand-crafted dicts. It would be much nicer to return a TargetFile that would contain the full "metadata" of the targetfile.
I'm not 100% sure if there are similar advantages to MetaFile
The text was updated successfully, but these errors were encountered: