You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is for the new client that's currently in experimental-client branch: but I'm hoping this issue is handled after the experimental client is merged to develop
We've not touched _preorder_depth_first_walk() or _visit_child_role() yet: they need some love:
First things:
type annotations would make the whole thing a lot easier to read and reason about
docstrings are old style
evaluate if some functionality could/should be in API (e.g. in DelegatedRole)
Then maybe:
maybe the code can be made simpler?
review the use of fnmatch(): it seems a bit suspicious (again using filesystem path functions for what I think are url fragments)
The text was updated successfully, but these errors were encountered:
This is for the new client that's currently in experimental-client branch: but I'm hoping this issue is handled after the experimental client is merged to develop
We've not touched
_preorder_depth_first_walk()
or_visit_child_role()
yet: they need some love:First things:
Then maybe:
The text was updated successfully, but these errors were encountered: