-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API: Add a constants module #1241
Comments
For the specific case mentioned, could it not be EDIT: actually the property might not be a good idea as you can't have class properties... |
Do we need a separate module other than the one added in #1470? |
@jku any opinions? |
The Metadata API and the updater implementation have evolved sufficiently that we don't need one central place for constants. |
Description of issue or feature request:
I think it will be useful to have a constant module in the new API.
This will help us to minimize the errors when writing hardcoded strings.
For example, the "snapshot.json" string is used often in the
Timestamp
class intuf/api/metadata.py
.@joshuagl raised awareness for that in this comment:
#1223 (comment)
Current behavior:
Harcoded strings.
Expected behavior:
Use constant containing the string.
The text was updated successfully, but these errors were encountered: