From 743b4da9c5d473e767c4f2ced1c238eb96dc8e02 Mon Sep 17 00:00:00 2001 From: Martin Vrachev Date: Mon, 29 Mar 2021 17:32:07 +0300 Subject: [PATCH] Add lines and file count information Signed-off-by: Martin Vrachev --- docs/adr/0007-validation-guideliness.md | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/adr/0007-validation-guideliness.md b/docs/adr/0007-validation-guideliness.md index 0a6e3a2876..b55d9646bc 100644 --- a/docs/adr/0007-validation-guideliness.md +++ b/docs/adr/0007-validation-guideliness.md @@ -46,11 +46,22 @@ Here is how all of our options compare against our requirements: | 1 | Validate function args everywhere | Limited | ✓ | Limited | ✓ | ✓ | | 2 | Custom deeper validation | ✓ | ✓ | ✓ | ✓ | ✓ | | 3 | Performance overhead | Minimal | [Fastest](https://pydantic-docs.helpmanual.io/benchmarks/) | [Slower](https://pydantic-docs.helpmanual.io/benchmarks/) | No information | No information | -| 4 | Number of new depedencies | 0 | 2 | 1 | 1 | 1 | +| 4 | New [depedencies ; files ; lines of code;] | [0; no info; no info] | [2; 25; 7681] | [1; 13; 2652] | [1; 906; 3] | [1; 906; 3] | | 5 | Support for all python versions | ✓ | ✓ | ✓ | ✓ | ✓ | | 6 | Code reuse for validation | ✓ | ✓ | ✓ | ✓ | ✓ | | 7 | Way to invoke all validators | ✓ | ✓ | ✓ | ✘ | ✓ | +For requirement number 4, the calculations were made with [sloccount](https://linux.die.net/man/1/sloccount) +on March 29-th 2021. All repositories were cloned on that day and calculated +by the same tool by invoking +```console +$ sloccount +$ sloccount --filecount +``` +Only source files were used when calculating the lines of code and number of +files (meaning all test files, doc folders, and other meta or configuration +files were excluded). + Bellow, in the following sections, there are additional pros, cons, and considerations for each of the options.