xtensa-build-zephyr.py: don't pass -c $plat.toml to rimage #8602
Conversation
The main branch hasn't supported IPC3 for tgl for a long time. Follow-up to commit a17c282 ("xtensa-build-zephyr: remove ipc option") Signed-off-by: Marc Herbert <[email protected]>
Rename: - tgl-cavs.toml to tgl.toml - tgl-h-cavs.toml to tgl-h.toml Remove the IPC3/IPC4 switch added by commit 6f71808 ("xtensa-build-zephyr.py: add ipc4 build support for tgl") This brings back consistency which is required for the .toml split (thesofproject#8490) Signed-off-by: Marc Herbert <[email protected]>
Let west/sign.py find the appropriate .toml file. This prepares for .toml modularization thesofproject#8490 Signed-off-by: Marc Herbert <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
marc-hb
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
There was a problem hiding this comment.
Wondering a bit if we need to bring some of this back later for other vendors to add IPC4 builds (on the side). Oh well, probably better do this in more generic way than this version.
This PR looks good, one mandatory CI check failing that needs to be clarified before merge.
|
@marc-hb we had a problem with tgl over the weekend, we managed to fix it, and the PR run shows that everything went well |
|
Thanks @wszypelt , https://sof-ci.01.org/sof-pr-viewer/#/build/PR8602/build13257497 is now green. cavs https://sof-ci.01.org/sofpr/PR8602/build972/devicetest/index.html and MTL https://sof-ci.01.org/sofpr/PR8602/build971/devicetest/index.html have only well known suspend/resume and GSC failures.
Good point and... good point. |
With the pre-processing of .toml files, a simple |
3 commits; separately tested in TEST PRs #8600 and #8601
This is a preliminary step for .toml modularization (#8490)