-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up IPC4 overlay for TGL/TGL-H #8212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup @aiChaoSONG !
Update: The uses of |
Please hold on to merge this, github action build need to be fixed. Edit and Update:
|
For TGL and TGL-H, IPC4 is the default build config, remove the '-i IPC4' option as it is not needed anymore. Signed-off-by: Chao Song <[email protected]>
For legacy CAVS platforms (TGL/ADL/EHL), the default build config is IPC4 now, and the overlay file is already emptied. Remove the option in this build script. Signed-off-by: Chao Song <[email protected]>
We build tgl and tgl-h with ipc4 by default, those ipc4 overlays are empty now, can be removed safely. Signed-off-by: Chao Song <[email protected]>
SOFCI TEST Update: Github action builds are good now, Jenkins build and test are also good. Need to fix Quickbuild builds. |
Converting to draft which is the simplest and fastest way to block merge - and can be easily filtered out by maintainers. Just one click each way. |
Waiting for QB updates. |
@aiChaoSONG @kv2019i The changes have been made, I added PR to the queue, I think the results will be available within 30 minutes |
@tmleman @aiChaoSONG so we can merge this, right? I wonder why MTL build passes now. We no longer need: zephyrproject-rtos/zephyr#62854 ? Later edit: This doesn't update the zephyr hash commit :). @aiChaoSONG good to merge? |
For legacy CAVS platforms (TGL/ADL/EHL), the default build config is IPC4 now,
and the overlay file is already emptied. Remove the option in this build script.