Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up IPC4 overlay for TGL/TGL-H #8212

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

aiChaoSONG
Copy link
Collaborator

@aiChaoSONG aiChaoSONG commented Sep 18, 2023

For legacy CAVS platforms (TGL/ADL/EHL), the default build config is IPC4 now,
and the overlay file is already emptied. Remove the option in this build script.

@aiChaoSONG aiChaoSONG changed the title xtensa-build-zephyr: remove ipc option clean up IPC4 overlay for TGL/TGL-H Sep 18, 2023
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @aiChaoSONG !

@aiChaoSONG
Copy link
Collaborator Author

Update: The uses of -i IPC4 is removed in CI, remove TODO, and force push for test.

@aiChaoSONG
Copy link
Collaborator Author

aiChaoSONG commented Sep 19, 2023

Please hold on to merge this, github action build need to be fixed.

Edit and Update:

  • Fix github action build for tgl and tgl-h

Chao Song added 3 commits September 19, 2023 09:11
For TGL and TGL-H, IPC4 is the default build config,
remove the '-i IPC4' option as it is not needed
anymore.

Signed-off-by: Chao Song <[email protected]>
For legacy CAVS platforms (TGL/ADL/EHL), the default
build config is IPC4 now, and the overlay file is
already emptied. Remove the option in this build
script.

Signed-off-by: Chao Song <[email protected]>
We build tgl and tgl-h with ipc4 by default, those
ipc4 overlays are empty now, can be removed safely.

Signed-off-by: Chao Song <[email protected]>
@aiChaoSONG
Copy link
Collaborator Author

aiChaoSONG commented Sep 19, 2023

SOFCI TEST

Update: Github action builds are good now, Jenkins build and test are also good. Need to fix Quickbuild builds.
@wszypelt please help to update quickbuild scripts, thanks.

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 19, 2023

Please hold on to merge this, ...

Converting to draft which is the simplest and fastest way to block merge - and can be easily filtered out by maintainers. Just one click each way.

@aiChaoSONG
Copy link
Collaborator Author

Waiting for QB updates.
@wszypelt Once you have updated TGL/TGL-h firmware build in QB, please comment, then we can merge this PR.

@wszypelt
Copy link

@aiChaoSONG @kv2019i The changes have been made, I added PR to the queue, I think the results will be available within 30 minutes

@aiChaoSONG aiChaoSONG marked this pull request as ready for review September 20, 2023 12:49
@dbaluta
Copy link
Collaborator

dbaluta commented Sep 20, 2023

@tmleman @aiChaoSONG so we can merge this, right? I wonder why MTL build passes now.

We no longer need: zephyrproject-rtos/zephyr#62854 ?

Later edit: This doesn't update the zephyr hash commit :).

@aiChaoSONG good to merge?

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 20, 2023

@dbaluta So my latest understand: this PR has no relation to Zephyr updates, but this PR needs to go in together with a aCI change on Intel side. I'll do a sync change tomorrow with @wszypelt .

So if we have Zephyr PR update passing CI today, we can proceed to merge that (today).

@kv2019i kv2019i merged commit b0afa39 into thesofproject:main Sep 21, 2023
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants