Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE][Zephyr] Implement arch_cpu_disable_core and cpu_power_down_core in wrapper.c #5094

Closed
kv2019i opened this issue Dec 15, 2021 · 7 comments
Closed

[FEATURE][Zephyr] Implement arch_cpu_disable_core and cpu_power_down_core in wrapper.c #5094

kv2019i opened this issue Dec 15, 2021 · 7 comments
Labels
enhancement New feature or request P2 Critical bugs or normal features Zephyr Issues only observed with Zephyr integrated

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Dec 15, 2021

Is your feature request related to a problem? Please describe.
Currently secondary cores are only powered down when DSP is put to suspend, or via out-of-band means (on Intel cAVS1.5, host controls power directly for the DSP cores).

Zephyr now implements interface to start/stop xtensa cores, so this should be used in wrapper.c.
@kv2019i kv2019i added enhancement New feature or request Zephyr Issues only observed with Zephyr integrated labels Dec 15, 2021
@lgirdwood
Copy link
Member

We need to start using native Zephyr APIs and wrap the xtos version of these functions.

@bkokoszx
Copy link
Collaborator

@mwasko fyi

@bkokoszx bkokoszx added the P2 Critical bugs or normal features label Dec 21, 2021
@kv2019i
Copy link
Collaborator Author

kv2019i commented Feb 1, 2022

Implemented with #5298 .

The native interface will be a Zephyr replacement of SOF runtime PM for DSP cores.

@lgirdwood
Copy link
Member

@kv2019i can we close now ?

@kv2019i
Copy link
Collaborator Author

kv2019i commented Feb 2, 2022

Yes, closing.

@kv2019i kv2019i closed this as completed Feb 2, 2022
@kv2019i
Copy link
Collaborator Author

kv2019i commented Feb 2, 2022

Unfortunately have to reopen this immediately back :( -> #5303

@kv2019i kv2019i reopened this Feb 2, 2022
@kv2019i
Copy link
Collaborator Author

kv2019i commented Jun 20, 2023

With @juimonen 's PR #7183 merged, we can close this.

@kv2019i kv2019i closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P2 Critical bugs or normal features Zephyr Issues only observed with Zephyr integrated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lgirdwood @bkokoszx @kv2019i