Skip to content

Commit

Permalink
xtensa-build-zephyr: remove ipc option
Browse files Browse the repository at this point in the history
For legacy CAVS platforms (TGL/ADL/EHL), the default
build config is IPC4 now, and the overlay file is
already emptied. Remove the option in this build
script.

Signed-off-by: Chao Song <[email protected]>
  • Loading branch information
Chao Song committed Sep 18, 2023
1 parent dac982a commit 99e0f2a
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions scripts/xtensa-build-zephyr.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ def parse_args():
help="List of platforms to build")
parser.add_argument("-d", "--debug", required=False, action="store_true",
help="Shortcut for: -o sof/app/debug_overlay.conf")
# TODO: Remove this argument once its use is removed in CI
parser.add_argument("-i", "--ipc", required=False, choices=["IPC4"],
help="""Applies --overlay <platform>/ipc4_overlay.conf
and a different rimage config. Valid only for IPC3 platforms supporting IPC4 too.""")
Expand Down Expand Up @@ -265,10 +266,6 @@ def parse_args():
if not args.use_platform_subdir:
args.use_platform_subdir=True
warnings.warn("The option '--fw-naming AVS' has to be used with '--use-platform-subdir'. Enable '--use-platform-subdir' automatically.")
if args.ipc != "IPC4":
args.ipc="IPC4"
warnings.warn("The option '--fw-naming AVS' has to be used with '-i IPC4'. Enable '-i IPC4' automatically.")


def execute_command(*run_args, **run_kwargs):
"""[summary] Provides wrapper for subprocess.run that prints
Expand Down Expand Up @@ -626,7 +623,7 @@ def rimage_options(platform_dict):
# test_00_01_load_fw_and_check_version
opts.append(("-b", "1"))

if args.ipc == "IPC4":
if platform_dict.get("IPC4_RIMAGE_DESC", None) is not None:
rimage_desc = platform_dict["IPC4_RIMAGE_DESC"]
else:
rimage_desc = platform_dict["name"] + ".toml"
Expand Down Expand Up @@ -725,13 +722,6 @@ def build_platforms():
if args.debug:
overlays.append(str(pathlib.Path(SOF_TOP, "app", "debug_overlay.conf")))

# The '-i IPC4' is a shortcut for '-o path_to_ipc4_overlay' (and more), we
# are good if both are provided, because it's no harm to merge the same
# overlay twice.
if args.ipc == "IPC4":
overlays.append(str(pathlib.Path(SOF_TOP, "app", "overlays", platform,
platform_dict["IPC4_CONFIG_OVERLAY"])))

if overlays:
overlays = ";".join(overlays)
build_cmd.append(f"-DOVERLAY_CONFIG={overlays}")
Expand Down

0 comments on commit 99e0f2a

Please sign in to comment.