Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] CI test for probes feature #922

Open
jsarha opened this issue Jun 15, 2022 · 2 comments
Open

[FEATURE] CI test for probes feature #922

jsarha opened this issue Jun 15, 2022 · 2 comments
Assignees
Labels
P2 Critical bugs or normal features type:test coverage gap This requires a new test case, not just fixing one

Comments

@jsarha
Copy link
Contributor

jsarha commented Jun 15, 2022

Probes feature is not at the moment tested in CI in any way and it has got broken several times.

Here is the basic documents about the usage of the feature:
https://thesofproject.github.io/latest/developer_guides/debugability/probes/index.html

I'll update the document above rather than write my own steps about how to get the feature working here.

@jsarha
Copy link
Contributor Author

jsarha commented Jun 15, 2022

Now looking at soc-test repo, the first question is how do I change the Linux and FW configs to add the probes support? I can I just ignore that and write a test and run it in my environment where I have all configurations in place?

@jsarha jsarha self-assigned this Jun 15, 2022
@kv2019i kv2019i added the P2 Critical bugs or normal features label Jun 16, 2022
@marc-hb
Copy link
Collaborator

marc-hb commented Jun 16, 2022

Now looking at soc-test repo, the first question is how do I change the Linux and FW configs to add the probes support?

That's completely outside the scope of sof-test. Our CI has code to do that (obviously) but it's not part of sof-test (and not open-source).

I can I just ignore that and write a test and run it in my environment where I have all configurations in place?

Absolutely, please "send patches"! We'll just make sure sof-test prints a nice error message when some dependency is not met. See for example a44dc39

@marc-hb marc-hb added P1 Blocker bugs or important features and removed P2 Critical bugs or normal features labels Sep 22, 2022
@marc-hb marc-hb added type:test coverage gap This requires a new test case, not just fixing one P2 Critical bugs or normal features and removed P1 Blocker bugs or important features labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Critical bugs or normal features type:test coverage gap This requires a new test case, not just fixing one
Projects
None yet
Development

No branches or pull requests

3 participants