Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Add DCblock to TGL, TGL-H, MTL, and LNL #177

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

singalsu
Copy link
Contributor

@singalsu singalsu commented Sep 4, 2023

This patch enables load of the DC blocker component.

@singalsu singalsu marked this pull request as ready for review September 4, 2023 13:31
Copy link

@btian1 btian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok to add it to mtl and lnl, for tgl, this is developed platform, shall we add as well? or there is a requirement?

@kv2019i
Copy link
Contributor

kv2019i commented Sep 5, 2023

@singalsu Needs rebase now that DRC is merged.

This patch enables load of the DC blocker component.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu
Copy link
Contributor Author

singalsu commented Sep 5, 2023

@singalsu Needs rebase now that DRC is merged.

Thanks! It's fixed now.

@singalsu
Copy link
Contributor Author

singalsu commented Sep 5, 2023

for tgl, this is developed platform, shall we add as well? or there is a requirement?

I plan to check and propose to change the IIR in HDA analog capture to dcblock so it would apply to all current sof-hda-generic platforms. There is no gain boost need for analog and also the DC pulse in capture start and when pressing headset buttons can be handled by dccomp (a simple 1st order IIR). It saves almost 5 MCPS if the filtering capability is sufficient.

@singalsu singalsu requested a review from btian1 September 5, 2023 10:56
@lgirdwood lgirdwood merged commit 7bc2958 into thesofproject:main Sep 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants