Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with x-debug 3 neither with php 8.0.1 #410

Closed
joaomfrebelo opened this issue Feb 7, 2021 · 5 comments
Closed

Does not work with x-debug 3 neither with php 8.0.1 #410

joaomfrebelo opened this issue Feb 7, 2021 · 5 comments

Comments

@joaomfrebelo
Copy link

With php_xdebug-3.0.2-8.0-vs16-nts-x86_64.dll enable gives the error:

PHP Version: 8.0.1 (WINNT)
PHPDox Version: 0.12.0
Exception: Error (Code: 0)
Location: phar://C:/Users/joao/.phive/phars/phpdox-0.12.0.phar/phpdox/shared/Environment.php (Line 46)

Call to undefined function TheSeer\phpDox\xdebug_disable()

#0 phar://C:/Users/joao/.phive/phars/phpdox-0.12.0.phar/phpdox/CLI.php(50): TheSeer\phpDox\Environment->ensureFitness()
#1 C:\Users\joao.phive\phars\phpdox-0.12.0.phar(485): TheSeer\phpDox\CLI->run()

Disabling the x-debug extension the error is;

PHP Version: 8.0.1 (WINNT)
PHPDox Version: 0.12.0
ErrorException: E_COMPILE_ERROR
Location: phar://C:/Users/joao/.phive/phars/phpdox-0.12.0.phar/vendor
/theseer/fxsl/src/fxsltprocessor.php (Line 187)

Declaration of TheSeer\fXSL\fXSLTProcessor::transformToDoc($node) mus
t be compatible with XSLTProcessor::transformToDoc(object $document,
?string $returnClass = null)

No stacktrace available

@jcfalcone
Copy link

Any feedback on this one?

@theseer
Copy link
Owner

theseer commented Mar 20, 2021

The xdebug issue part of this ticket is a duplicate if #409. For now, please disable xdebug while running phpDox or use the master branch rather than the release.

The XSLProcessor part of this ticket is a BC break in PHP: For reasons I do not yet understand, the signatures got changed to require a generic object type rather than a specific DOMNode or DOMDocument. I consider that a bug in PHP, as passing anything else than a DOMNode makes no sense whatsoever.
I'll see what can be done for that.

@theseer
Copy link
Owner

theseer commented Mar 20, 2021

Okay, this cannot be fixed in a way that also works for PHP 7: The signatures are simply incompatible between 7.x and 8.x.

@theseer
Copy link
Owner

theseer commented Mar 20, 2021

Please try with current master.

@theseer
Copy link
Owner

theseer commented Mar 20, 2021

I'll try to make a new release later this weekend.

@theseer theseer closed this as completed Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants