Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOSS] Tests failing #47

Closed
hgandhi2411 opened this issue Nov 3, 2022 · 2 comments · Fixed by #50
Closed

[JOSS] Tests failing #47

hgandhi2411 opened this issue Nov 3, 2022 · 2 comments · Fixed by #50

Comments

@hgandhi2411
Copy link

Two tests in test_thermoengine.py are failing. You can see the log from running pytest pytests/ here
@gdmiron
Copy link
Member

gdmiron commented Nov 8, 2022

Tests pass in windows and Ubuntu. Need to investigate this in depth #37 since this is OS dependent. Some round off bug.

@gdmiron
Copy link
Member

gdmiron commented Nov 26, 2022

should be fixed #50

@gdmiron gdmiron closed this as completed Nov 26, 2022
@gdmiron gdmiron linked a pull request Nov 26, 2022 that will close this issue
Fix for spdlog link and tests #50
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for spdlog link and tests gdmiron/thermofun
2 participants
@hgandhi2411 @gdmiron