Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

Github Issues button in footer #38

Open
frattaro opened this issue Apr 1, 2017 · 2 comments
Open

Github Issues button in footer #38

frattaro opened this issue Apr 1, 2017 · 2 comments

Comments

@frattaro
Copy link
Contributor

frattaro commented Apr 1, 2017

Is the 'Issues' button count supposed to show Issues + Pull Requests? At least, that's what I think is showing.

@DominicBisset
Copy link
Contributor

DominicBisset commented Apr 3, 2017

I looked into it but there isn't a quick fix.

It's a quirk with the underlying GitHub API - historically there was less of a difference between an issue and a PR so they share the same underlying framework and get included in the same summary count on the repos endpoint. There is no readily available alternative to pipe into the button control. You can determine which are pull requests and which are issues by looking at the the issues endpoint but can only get a count by loading all of the data. That data is paginated, limited to 30 entries per page, so we'd probably hit a rate limiter once the project hits some level of scale.

Even if we go down this route we'd then have to re-implement the button controls to handle our custom API since they are quite tailored towards the GitHub API.

@DominicBisset
Copy link
Contributor

This was solved by @woubuc as part of PR #43, though it did loose the links to the relevant pages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants