Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never use section on aarch64 (#277) #292

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

catap
Copy link
Contributor

@catap catap commented Oct 1, 2022

Closes #277

@catap
Copy link
Contributor Author

catap commented Oct 1, 2022

@thepowersgang I not sure about condition. Maybe invert it and keep section attribute only for x86 and x86_64 is better idea.

@catap
Copy link
Contributor Author

catap commented Oct 13, 2022

@thepowersgang just a reminder about this one

@catap
Copy link
Contributor Author

catap commented Nov 7, 2022

@thepowersgang ping here!

@thepowersgang
Copy link
Owner

I'm not sure hard-disabling the use of section annotations is the correct solution to that linked issue.
Wouldn't adding patch for that particular bad annotation be a better solution?

@catap
Copy link
Contributor Author

catap commented Nov 9, 2022

@thepowersgang I haven't found the place in sources which triggers such behaviour. Anyway, section isn't supported at aarch64 => seems logical to not use it.

@thepowersgang
Copy link
Owner

If that's the case - then include that in the commit and in a source comment

@catap
Copy link
Contributor Author

catap commented Nov 9, 2022

@thepowersgang seems I found much better solution.

I've started to find any proof that aarch64 doesn't support section and haven't found one. In fact I found that it should work.

=> I've started digging as you suggested and found an issue in rust-curl which is used. This issue was fixed in upstream. So, I've backported it to rust-curl which is used for 1.54.0 :)

@catap
Copy link
Contributor Author

catap commented Nov 9, 2022

Thus, you may see that original issue alexcrichton/curl-rust#417 is near the same that I had at the end of #277:

  = note: ld: reference to symbol (which has not been assigned an address) __ZN4curl4init9INIT_CTOR17h97cc33cf050cb462E in '__ZN4curl4init17ha644d831c2a57f65E' from /Users/cormac/git/tryout/libcurl-monterey/target/debug/deps/libcurl-0f9cbb7dde66dd88.rlib(curl-0f9cbb7dde66dd88.curl.0b6dcf6e-cgu.2.rcgu.o) for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

@thepowersgang thepowersgang merged commit 1b1416b into thepowersgang:master Nov 10, 2022
@catap catap deleted the aarch64-section branch November 10, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to bootstrap rust-1.54.0 on aarch64 / macOS 12
2 participants