-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Never use section on aarch64 (#277) #292
Conversation
@thepowersgang I not sure about condition. Maybe invert it and keep section attribute only for |
@thepowersgang just a reminder about this one |
@thepowersgang ping here! |
I'm not sure hard-disabling the use of section annotations is the correct solution to that linked issue. |
@thepowersgang I haven't found the place in sources which triggers such behaviour. Anyway, section isn't supported at aarch64 => seems logical to not use it. |
If that's the case - then include that in the commit and in a source comment |
0e4609d
to
5b492a5
Compare
@thepowersgang seems I found much better solution. I've started to find any proof that aarch64 doesn't support section and haven't found one. In fact I found that it should work. => I've started digging as you suggested and found an issue in rust-curl which is used. This issue was fixed in upstream. So, I've backported it to rust-curl which is used for 1.54.0 :) |
Thus, you may see that original issue alexcrichton/curl-rust#417 is near the same that I had at the end of #277:
|
Closes #277