Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for valid mime type is too simple, fails for some #73

Closed
smuriu opened this issue Sep 28, 2015 · 1 comment
Closed

Test for valid mime type is too simple, fails for some #73

smuriu opened this issue Sep 28, 2015 · 1 comment
Labels
bug Something isn't working

Comments

@smuriu
Copy link

smuriu commented Sep 28, 2015

In League\Uri\Components\DataPath, mime is tested for validity with the simple regex ',^[a-z-\/+]+$,i'; which fails for valid mime types that contain a digit. e.g. video/mp4
@nyamsprod nyamsprod added the bug Something isn't working label Sep 28, 2015
nyamsprod referenced this issue in thephpleague/uri Sep 28, 2015
@nyamsprod
Resolve issue #21
3e662d3
@nyamsprod
Copy link
Member

@smuriu I've made an update to the mimetype filter validation method tell me what you think about it

nyamsprod referenced this issue in thephpleague/uri Sep 28, 2015
@nyamsprod
Resolve issue #21
11e820f
nyamsprod referenced this issue in thephpleague/uri Sep 29, 2015
@nyamsprod
Resolve issue #21
f62137f
nyamsprod referenced this issue in thephpleague/uri Oct 6, 2015
@nyamsprod
Merge pull request #22 from thephpleague/bugfix/mimetype
7586ffd 
Resolve issue #21
@nyamsprod nyamsprod transferred this issue from thephpleague/uri Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nyamsprod @smuriu