Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release compatible with Omnipay v2 #8

Open
rquadling opened this issue Sep 19, 2017 · 8 comments
Open

Release compatible with Omnipay v2 #8

rquadling opened this issue Sep 19, 2017 · 8 comments

Comments

@rquadling
Copy link

Hi.

With the recent merge of #7, we would like to no longer use the fork at https://github.com/jtgrimes/omnipay-dummy.

Can there be a release please?

Can Omnipay Common be set for V2 or V3 as we use 12 (yep just counted) drivers and they are all on v2.

@delatbabel
Copy link
Contributor

@barryvdh can I leave this with you please since you appear to know more about what's going on with the 3.0 alphas than I do.

@rquadling
Copy link
Author

Hi. Please can the merge at cc603bd be reverted? As things stand, this package cannot be released as a V2 driver due to this change.

@barryvdh
Copy link
Member

What do you mean? There are 2.x tags that you can use for Omnipay V2

@barryvdh
Copy link
Member

Oh right, there is not tag with that commit merged for v2.
It seems dummy 3.0 alpha 1 is targeted at Omnipay v2. I guess that was done because of the BC breaks. In that case omnipay-dummy v3 is compatible with Omnipay v2 and v4 will be compatible with Omnipay v3

@rquadling
Copy link
Author

In short, every commit after the merge is ONLY for Omnipay V3.

@barryvdh
Copy link
Member

I've setup branch 2.2 and tagged v2.2.0 with that commit reverted. Better now?

@rquadling
Copy link
Author

Can you do a release, rather than just tagging the repo. Packagist isn't seeing 2.2.0. https://packagist.org/packages/omnipay/dummy

And so you get ...

Loading composer repositories with package information
Updating dependencies (including require-dev)         
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package omnipay/dummy ^2.2.0 exists as omnipay/dummy[dev-master, 3.0.x-dev, v2.0.0, v2.1.0, v2.1.1, v2.1.2, v3.0-alpha.1, dev-feature-additional-request-types] but these are rejected by your constraint.

@rquadling
Copy link
Author

That's attempting to use ^2.2.0. Without this constraint, v2.1.2 is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants