Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release breaks providers with AccessToken to AccessTokenInterface #753

Closed
plandolt opened this issue Nov 21, 2018 · 4 comments
Closed

Comments

@plandolt
Copy link
Contributor

The abstract method abstract public function getResourceOwnerDetailsUrl(AccessTokenInterface $token); from src/Provider/AbstractProvider.php is now a problem as a provider has still public function getResourceOwnerDetailsUrl(AccessToken $token). This results in a "Declaration of must be compatible with" kind of error.

@fzieris
Copy link

fzieris commented Nov 21, 2018

Same error as in #752

@plandolt
Copy link
Contributor Author

closed in favour of #752 (2 minutes earlier :))

@ramsey
Copy link
Contributor

ramsey commented Nov 22, 2018

Please check release 2.4.1 and confirm that it fixes this issue. Thanks!

@jesseleite
Copy link

Thank you for this fix! I fought with this for a bit, but see that you guys just pushed fix 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants