Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpseclib - later versions (>0.3.8)? #12

Closed
judgej opened this issue Sep 22, 2015 · 13 comments
Closed

phpseclib - later versions (>0.3.8)? #12

judgej opened this issue Sep 22, 2015 · 13 comments

Comments

@judgej
Copy link
Member

judgej commented Sep 22, 2015

phpseclib 0.3.8 is a year old now. Versions 1.0.0 and 2.0.0 are now out, and are being used by framewords such as Laravel 5.1. This makes installing flysystem-sftp difficult on modern frameworks.

I don't know what v1 and v2 of phpseclib bring, and whether they would work for flysystem-sftp, but would they be compatible? Could the version requirements be extended?

@judgej judgej changed the title phpseclib - later versions? phpseclib - later versions (>0.3.8)? Sep 22, 2015
@judgej
Copy link
Member Author

judgej commented Sep 22, 2015

Rate of development on phpseclib is pretty crazy. Nice to see, but keeping up is a full time job :-)

@judgej
Copy link
Member Author

judgej commented Sep 22, 2015

Okay, going crazy - trying to install from a fork with a dependency of phplibsec 2.0 to see if it all works:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/academe/flysystem-sftp.git"
        }
    ],
    "require": {
        "phpseclib/phpseclib": "^2.0",
        "league/flysystem-sftp": "~1.0"
    }
}

Still getting the error:

  Problem 1
    - league/flysystem-sftp 1.0.6 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.5 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.4 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.3 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.2 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.1 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.0 requires phpseclib/phpseclib ~0.3.7 -> no matching package found.
    - league/flysystem-sftp 1.0.6 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.5 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.4 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.3 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.2 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.1 requires phpseclib/phpseclib ~0.3.8 -> no matching package found.
    - league/flysystem-sftp 1.0.0 requires phpseclib/phpseclib ~0.3.7 -> no matching package found.
    - Installation request for league/flysystem-sftp ~1.0 -> satisfiable by league/flysystem-sftp[1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6].

It's as though composer is ignoring the repositories section. Why would it do that? Is composer broken - getting its composer.json from packagist even when it's told what repository to in? Ah, no - I need to go to dev-master. Dhoh.

Edit: All installed, but must go, will test later.

@andreybolonin
Copy link

#11

@frankdejonge
Copy link
Member

@judgej which laravel package uses the phpseclib package? I didn't see anything in the laravel/framework repo.

@judgej
Copy link
Member Author

judgej commented Sep 22, 2015

Hmm, not sure, maybe it's something else I have installed.

@judgej
Copy link
Member Author

judgej commented Sep 22, 2015

I can't find anything that uses it, except a direct require in my history from a few weeks ago. Maybe I installed it while trying something out and forgot. I've just removed it (2.0.0) and now league/flysystem-sftp installs okay by pulling in phpseclib/phpseclib (0.3.10).

Right, so what I have now seems to work, and so long as nothing else needs a newer flysytem-sftp then I'm okay. I'll leave it at that for now. Sorry for wasting your time!

It looks like @pilotftzi is on the case with 2.0.0 anyway. Not sure if you want to close this issue, or leave it open as a placeholder for PR #11 ?

@soee
Copy link

soee commented Oct 9, 2015

If we do not jump to 2.0, flysystem-sftp will fail on PHP7 because of phpseclib. See this.

@mediamonks-robert
Copy link

I'm having an issue with a sftp server where I can not connect with, it just hangs. This is caused by a bug in phpseclib ~0.3 which was fixed in ~1.0. Please update the dependency :)

@frankdejonge
Copy link
Member

@soee sorry for the wait guys, I'll be tackling this issue tomorrow.

@frankdejonge
Copy link
Member

Sorry for the wait people, been super busy. I'll get this up to date tomorrow, possibly tonight fingers crossed.

@frankdejonge
Copy link
Member

It's released as 1.0.7

@soee
Copy link

soee commented Oct 25, 2015

@frankdejonge Than you very much! :)

@mediamonks-robert
Copy link

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants